Replace setup.py with equivalent pyproject.toml
#539
Conversation
|
I will automatically update this comment whenever this PR is modified
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #539 +/- ##
============================================
Coverage 66.27% 66.27%
============================================
Files 36 36
Lines 3072 3072
Branches 537 537
============================================
Hits 2036 2036
Misses 948 948
Partials 88 88 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Tested locally using python -m pip install -U git+https://github.com/icesat2py/icepyx.git@pyproject and install worked:
Building wheels for collected packages: icepyx
Building wheel for icepyx (pyproject.toml) ... done
Created wheel for icepyx: filename=icepyx-1.1.1.dev6+g0c167ac-py3-none-any.whl size=84019 sha256=639020f3dae60c23936d3658e4b0a92a47855f997587f693fe58c6de632b14b4
Stored in directory: /tmp/pip-ephem-wheel-cache-263bvbb_/wheels/82/71/dc/27dcd9147f97ee37fa865a9c6c34839d9163fb43e99929bc32
Successfully built icepyx
Installing collected packages: icepyx
Successfully installed icepyx-1.1.1.dev6+g0c167ac
Just one other small suggestion below 👇
|
Thanks @weiji14 for the review! I'm looking at those UML changes and they look really similar, but shifted around a little bit. Should I just ignore them? |
Probably ok to ignore them, I think the UML generator isn't very deterministic... Can check with @JessicaS11? |
|
Oops, the publish to TestPyPI CI is failing, @mfisher87, could you update this line as well? |
|
Woops! My mistake! #541 |
| license = {file = "LICENSE"} | ||
| readme = "README.rst" | ||
|
|
||
| requires-python = "~=3.7" |
There was a problem hiding this comment.
Oh shoot, totally overlooked this line. This should have been >=3.7 instead...
👋
https://setuptools.pypa.io/en/latest/userguide/quickstart.html#transitioning-from-setup-py-to-declarative-config